avm2: Add infallible methods to get and set dynamic object properties #20998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-avm2
moulins
reviewed
Jul 15, 2025
Lord-McSweeney
force-pushed
the
avm2-dynamic-prop
branch
from
80817eb to
a19e226
Compare
moulins
reviewed
Jul 16, 2025
Lord-McSweeney
force-pushed
the
avm2-dynamic-prop
branch
from
a19e226 to
62e45de
Compare
`set_dynamic_property` works just like `set_string_property_local`, except it takes a Mutation instead of an Activation and an AvmString instead of a Multiname
This allows us to make `avmplus::describe_internal_body` infallible
These functions replace `get_string_property_local` and `delete_string_property_local`
Lord-McSweeney
force-pushed
the
avm2-dynamic-prop
branch
from
62e45de to
b400449
Compare
Lord-McSweeney
removed
the
waiting-on-review
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Jul 20, 2025
------------------------------------------------------------------------------------------ dolphin-emu.mk b2b2808d014fec0c8510ebbf6e91c850c7417925 # Version: Commits on Jul 19, 2025 ------------------------------------------------------------------------------------------ Merge pull request #13812 from Dentomologist/memoryviewwidget_fix_updates_at_end_of_address_space MemoryViewWidget: Fix updates at end of address space, ------------------------------------------------------------------------------------------ duckstation.mk c922893b6ff4d5b83631fbcb39c59596c35570d2 # Version: Commits on Jul 19, 2025 ------------------------------------------------------------------------------------------ GameDB: Bump MGS max speedup cycles to 100k Causes screen flickering at 80k, game crash at 70k, still some flickering at 90k., --------------------------------------------------- pcsx2.mk v2.5.70 # Version: Commits on Jul 19, 2025 --------------------------------------------------- - [GS/HW: Remove handling of provoking first vertex in early pipeline.](PCSX2/pcsx2#12986) ------------------------------------------------------------------------------------- ppsspp.mk 28d2bd5b0d55e8790b64d4566918ca76bf394c30 # Version: Commits on Jul 18, 2025 ------------------------------------------------------------------------------------- Merge pull request #20643 from hrydgard/windows-minimize-vulkan Windows/Vulkan: Correctly handle minimizing and restoring the window, --------------------------------------------------------------- ruffle.mk nightly-2025-07-19 # Version: Commits on Jul 19, 2025 --------------------------------------------------------------- ## What's Changed * chore: Update translations by @RuffleBuild in ruffle-rs/ruffle#21023 * avm2: Add infallible methods to get and set dynamic object properties by @Lord-McSweeney in ruffle-rs/ruffle#20998 * chore: Update required `webdriverio` version by @torokati44 in ruffle-rs/ruffle#21026 * chore: Bump `on-headers` node package to `1.1.0` fully by @torokati44 in ruffle-rs/ruffle#21025 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-07-18...nightly-2025-07-19, -------------------------------------------------------------------------------------- shadps4.mk 0b72a795eb12532c359ebbe9a507b7fbab105b49 # Version: Commits on Jul 18, 2025 -------------------------------------------------------------------------------------- vk_rasterizer: Improve stencil clears (#3268), ------------------------------------------------------------------------------------------- jazz2-native.mk 1f121a4970470e068e9a28ddf1be6be9dee93146 # Version: Commits on Jul 18, 2025 ------------------------------------------------------------------------------------------- Refactoring, ---------------------------------------------------------------------------------------- openjkdf2.mk a39d8b6956d164a533886aa49ead04b071e4a49a # Version: Commits on Jul 19, 2025 ---------------------------------------------------------------------------------------- Add SITH_DEBUG_STRUCT_NAMES and access some hashtables via crc to save memory, ---------------------------------------------------------------------------------------- openmohaa.mk 83a32c2635757580b71c125b7c9ea55aa825342b # Version: Commits on Jul 18, 2025 ---------------------------------------------------------------------------------------- Fix incorrect mins/maxs value for SpotWouldTelefrag This caused telefrags on multiplayer with an high number of players, ---------------------------------------------------------------------------------------------------- sdl2-gamecontrollerdb.mk dce2d3593c6a96a57716d13d58aa3b1d4965fe6f # Version: Commits on Jul 18, 2025 ---------------------------------------------------------------------------------------------------- Adds HHL SInput Linux mappings thanks @bemug and @mitchellcairns, ---------------------------------------------------------------------------------------- doomretro.mk 8c2db1f850b4204b858cafae06f9afa76940edba # Version: Commits on Jul 19, 2025 ---------------------------------------------------------------------------------------- Fix possible crash if `r_corpses_moreblood` CVAR `on`, ------------------------------------------------------------------------------------- gzdoom.mk 30cc12912bddf6a27596f588a322ca560ef6f2ff # Version: Commits on Jul 19, 2025 ------------------------------------------------------------------------------------- Added uint typedef under windows, ---------------------------------------------------------------------------------------------- libretro-ppsspp.mk 28d2bd5b0d55e8790b64d4566918ca76bf394c30 # Version: Commits on Jul 18, 2025 ---------------------------------------------------------------------------------------------- Merge pull request #20643 from hrydgard/windows-minimize-vulkan Windows/Vulkan: Correctly handle minimizing and restoring the window, --------------------------------------------------------------------------------------------- libretro-vba-m.mk 88d58db0e9d7bd1ad403a634e07969fa02f4b85a # Version: Commits on Jul 19, 2025 --------------------------------------------------------------------------------------------- translations: transifex pull Signed-off-by: Rafael Kitover <[email protected]>,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.